Skip to content

Add focused build-review renderer tests#112

Merged
coreytshaffer merged 1 commit into
mainfrom
trial/opus5-build-review-report-tests
Jul 25, 2026
Merged

Add focused build-review renderer tests#112
coreytshaffer merged 1 commit into
mainfrom
trial/opus5-build-review-report-tests

Conversation

@coreytshaffer

Copy link
Copy Markdown
Owner

Summary

  • Adds one focused test file for the public render_markdown and render_html build-review report APIs.
  • Covers deterministic repeated rendering, adversarial HTML escaping, Markdown fence neutralization, em-dash rendering for unknown counts, empty-collection fallbacks, and pending/completed decision views.
  • Makes no production behavior change.

Opus 5 coding trial

This change originated as a bounded Opus 5 coding trial and is presented for review on its technical merits:

  • one new test file;
  • ten focused tests;
  • production code untouched;
  • configuration, dependencies, CLI, persistence, authorization, routing, execution, and documentation untouched.

The trial succeeded on coding, testing, scope retention, and self-review. A persistent minor limitation remains in exact output-format compliance, which does not affect this diff.

Validation

  • Focused: 10 passed in 0.13s
  • Full suite: 1249 passed, 5 skipped, 1 xfailed in 106.19s
  • The existing CR-YK-001 concurrency xfail is unchanged.
  • git diff --cached --check passed.
  • Staged scope contained exactly tests/test_build_review_report.py.

Deferred observation

Review identified three raw HTML interpolations in the production renderer: files_changed, finding severity in a class attribute, and completed decision status in a class attribute. Ordinary packet construction constrains these values, so this is a small defense-in-depth hardening candidate rather than an emergency vulnerability.

That production hardening is intentionally excluded from this test-only PR and requires a separate bounded change.

@netlify

netlify Bot commented Jul 25, 2026

Copy link
Copy Markdown

Deploy Preview for poetic-quokka-0fd859 ready!

Name Link
🔨 Latest commit d6d0dd6
🔍 Latest deploy log https://app.netlify.com/projects/poetic-quokka-0fd859/deploys/6a6441b2056b1800089eeae7
😎 Deploy Preview https://deploy-preview-112--poetic-quokka-0fd859.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coreytshaffer
coreytshaffer marked this pull request as ready for review July 25, 2026 04:58
@coreytshaffer
coreytshaffer merged commit 1adc7d5 into main Jul 25, 2026
7 checks passed
@coreytshaffer
coreytshaffer deleted the trial/opus5-build-review-report-tests branch July 25, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant