fix: match pod names truncated by apiserver generateName - #16
Merged
Conversation
The Job controller sets the pod generateName to job.Name + "-" and the apiserver truncates that base to 58 chars (63 minus the 5-char random suffix) before appending the suffix. Argo Rollouts names its Jobs <analysisRun UID>.<metric>.<attempt>, and the 36-char UID means a metric name over ~18 chars pushes the base past the limit, so the attempt suffix and the dash are silently cut from the pod name. buildQuery derived its regex from the untruncated Job name, so it could never match those pods and the log pane came up empty. Reproduce the apiserver rule via podNamePrefix so the regex is correct for any Job name length: unchanged below 58 chars, truncated to the same prefix above it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Job controller sets the pod generateName to job.Name + "-" and the apiserver truncates that base to 58 chars (63 minus the 5-char random suffix) before appending the suffix. Argo Rollouts names its Jobs .., and the 36-char UID means a metric name over ~18 chars pushes the base past the limit, so the attempt suffix and the dash are silently cut from the pod name.
buildQuery derived its regex from the untruncated Job name, so it could never match those pods and the log pane came up empty. Reproduce the apiserver rule via podNamePrefix so the regex is correct for any Job name length: unchanged below 58 chars, truncated to the same prefix above it.