docs(dropdown): align the responsive alignment examples to the toggle - #384
Merged
Conversation
With responsive alignment Popper is off and the menu is placed by CSS, relative to the dropdown itself. The default variant renders that as a full-width block, so the examples dropped the menu against the edge of the container instead of the button. They now set variant="btn-group", which wraps just the toggle, and the page says why it is needed. The prose named an `aligment` prop that does not exist, in a syntax the component never accepted. The examples also passed color to CDropdown, which takes no such prop — it only reached the DOM as an attribute on the wrapper, while the toggle carried its own color all along.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With responsive alignment Popper is off and the menu is placed by CSS, relative to the dropdown itself. The default variant renders that as a full-width block, so both examples dropped the menu against the edge of the container instead of the button. They now set
variant="btn-group", which wraps just the toggle, and the page says why it is needed.Two more fixes on the same section:
aligmentprop that does not exist, in a syntax the component never accepted.colortoCDropdown, which takes no such prop, so it only reached the DOM as an attribute on the wrapper. The toggle carried its owncolorall along, so nothing changes visually.