[Psalm] ignore doctrine/dbal 4.5 schema API deprecations - #3267
Merged
Merged
Conversation
doctrine/dbal 4.5 deprecates the classic schema builder API and marks Schema::__construct as internal. The replacement table editors are not available on all versions covered by ^4.2, so these are downgraded to info like the existing Table::setPrimaryKey / Column::__construct entries. Refs coreshop#3266
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3266
psalm.xml
doctrine/dbal 4.5.0 (resolved in the
Deps highestjob) deprecatesSchema::createTable,Table::addColumn/addIndex/addUniqueIndex/addOption,Column::setLength/getTypeand marksSchema::__constructas internal. These are downgraded to info, following the existing entries forTable::setPrimaryKey/Column::__construct.Not done: migrating to the new table editor API, since
doctrine/dbal: ^4.2is still supported and those APIs aren't available on all covered versions.Test
xmllint --schema vendor/vimeo/psalm/config.xsd psalm.xml→ validatesSupersedes #3265.
Closes #3266