Port DOOM-ED to latest Orion and expand triangulation edge-case coverage - #45
Merged
Conversation
…on tests Agent-Logs-Url: https://github.com/corepunch/doom-ed/sessions/fc1ede01-5aba-4b38-a775-5847d88fea98 Co-authored-by: corepunch <83646194+corepunch@users.noreply.github.com>
Agent-Logs-Url: https://github.com/corepunch/doom-ed/sessions/fc1ede01-5aba-4b38-a775-5847d88fea98 Co-authored-by: corepunch <83646194+corepunch@users.noreply.github.com>
Agent-Logs-Url: https://github.com/corepunch/doom-ed/sessions/fc1ede01-5aba-4b38-a775-5847d88fea98 Co-authored-by: corepunch <83646194+corepunch@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
corepunch
May 10, 2026 13:47
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request strengthens DOOM-ED’s geometry verification by expanding the triangulation test suite with additional edge cases, and hardens the build bootstrap by auto-initializing the Orion UI submodule when missing.
Changes:
- Added polygon area and output-vertex provenance helpers to improve triangulation correctness assertions.
- Expanded
triangulate_testcoverage to include collinear-only input, collinear edge points, repeated points, and larger convex polygons. - Updated the root
Makefileto auto-rungit submodule update --init --recursive uiwhenui/Makefileis missing.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/triangulate_test.c |
Adds new helpers and multiple triangulation edge-case tests (degenerate, collinear, repeated points, scaling). |
Makefile |
Auto-initializes the ui submodule when needed before building liborion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates DOOM-ED to track the latest Orion UI framework and strengthens geometry verification where coverage was weakest. The scope is compatibility with current Orion plus materially broader triangulation correctness checks.
Orion upgrade
uisubmodule to latest upstreammain(current Orion head).Build bootstrap hardening
Makefileto auto-initialize theuisubmodule when missing, avoiding first-run failures from fresh clones/checkouts.Triangulation coverage expansion
tests/triangulate_test.cwith focused edge/correctness cases: