*/release-checklist: add step for merging fast-track merge requests - #238
Open
prestist wants to merge 1 commit into
Open
*/release-checklist: add step for merging fast-track merge requests#238prestist wants to merge 1 commit into
prestist wants to merge 1 commit into
Conversation
jlebon
reviewed
Aug 7, 2024
| {%- if do_fast_track %} | ||
| - [ ] [Submit a fast-track](https://github.com/coreos/fedora-coreos-config/actions/workflows/add-override.yml) for FCOS testing-devel | ||
| - [ ] [Submit a fast-track](https://github.com/coreos/fedora-coreos-config/actions/workflows/add-override.yml) for FCOS next-devel if it is [open](https://github.com/coreos/fedora-coreos-pipeline/blob/main/next-devel/README.md) | ||
| - [ ] Approve and merge the fast-track [Pr(s)](https://github.com/coreos/fedora-coreos-config/pulls) |
Member
There was a problem hiding this comment.
Hmm, sorry I misunderstood what you were suggesting. I think I'd still prefer that a second person does the code review. But the releaser should be responsible for ensuring it eventually gets merged (e.g. getting reviews or rebasing if needed).
prestist
force-pushed
the
add-note-about-merging-fast-track
branch
from
August 8, 2024 13:16
beb2ad1 to
f1843ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After latest release we noticed fast-track pr needed a rebase due to order of pr's being merged lets instead have the person releasing the project take ownership of that responsibility.