Skip to content

manifests: add udisks2 so fwupd can work as expected - #4316

Merged
dustymabe merged 2 commits into
coreos:testing-develfrom
Rolv-Apneseth:udisks2
Aug 27, 2026
Merged

dustymabe merged 2 commits into
coreos:testing-develfrom
Rolv-Apneseth:udisks2

Conversation

@Rolv-Apneseth

Copy link
Copy Markdown
Member

fwupd relies on udisks2 to detect + mount ESPs. Let's add it since it no longer requires Python, and it allows fwupd to work as expected on FCOS (for non-RAID systems).

Part of the work for coreos/fedora-coreos-tracker#1623, and related to coreos/bootupd#1138.

Previous breakdown of size + added packages: coreos/fedora-coreos-tracker#1623 (comment)

@Rolv-Apneseth

Copy link
Copy Markdown
Member Author

Seems like a transitive dep is causing the CI to fail, is that expected?

[2026-08-21T13:42:15.926Z] Exception: found unlocked RPM in strict mode: (none)	nspr-4.39.0-3.fc44.x86_64	nspr-4.39.0-3.fc44	nspr-4.39.0-3.fc44.x86_64	nspr-4.39.0-3.fc44

@dustymabe

Copy link
Copy Markdown
Member

hmm not sure..

but you should be able to do a local build and copy the lockfile from builds/latest/x86_64/manifest-lock.generated.x86_64.json into place over manifest-lock.x86_64.json I think.

dustymabe
dustymabe previously approved these changes Aug 21, 2026
@Rolv-Apneseth

Copy link
Copy Markdown
Member Author

Konflux failed with:

404, message='Not Found', url='https://kojipkgs.fedoraproject.org/repos-dist/coreos-pool/latest/x86_64/Packages/l/libatasmart-0.19-32.fc44.x86_64.rpm'

That's just the first indirect dependency, so I assume others would fail too. Is there some gap with how indirect/transitive deps are added into our package pool for Konflux?

fwupd relies on udisks2 to detect + mount ESPs. Let's add it since it no
longer requires Python, and it allows fwupd to work as expected on FCOS
(for non-RAID systems).
@jbtrystram

Copy link
Copy Markdown
Member

Konflux failed with:

404, message='Not Found', url='https://kojipkgs.fedoraproject.org/repos-dist/coreos-pool/latest/x86_64/Packages/l/libatasmart-0.19-32.fc44.x86_64.rpm'

That's just the first indirect dependency, so I assume others would fail too. Is there some gap with how indirect/transitive deps are added into our package pool for Konflux?

yeaaah so this is caused by how we hacked hermetic builds to work. Long story short, this package is not yet tagged into coreos-pool and will only be when this PR merges. So until then, hermetic build won't work.

@joelcapitao I think this has caused confusion multiples times already, so we should find a way to turn off hermetic builds on PRs that edit the lockfiles. There's probably some one-cel expression and patch magic we can do to achieve that.
Or disable hermetic on PRs altogether if we can't make it work. (but i don't like that much)

@Rolv-Apneseth
Rolv-Apneseth force-pushed the udisks2 branch 2 times, most recently from 652e13d to 2651e0a Compare August 26, 2026 09:22

@dustymabe dustymabe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
dustymabe merged commit f1f63d8 into coreos:testing-devel Aug 27, 2026
5 of 9 checks passed
@Rolv-Apneseth
Rolv-Apneseth deleted the udisks2 branch August 27, 2026 15:48
@joelcapitao

Copy link
Copy Markdown
Member

yeaaah so this is caused by how we hacked hermetic builds to work. Long story short, this package is not yet tagged into coreos-pool and will only be when this PR merges. So until then, hermetic build won't work.
@joelcapitao I think this has caused confusion multiples times already, so we should find a way to turn off hermetic builds on PRs that edit the lockfiles. There's probably some one-cel expression and patch magic we can do to achieve that.

This is a "not-yet-tagged-in-coreos-pool" issue but is the first time we hit this variant IIRC. In that case, we're adding a new set of packages. In the previous case c.f. coreos/fedora-coreos-tracker#2155, it was a race condition.
As we designed the Konflux hermetic build logic to rely only on the manifest lockfiles i.e we basically derive manifest lockfiles -> hermeto lockfiles, the next time I think we better have to 'abuse' on the override/fast-track mechanism:

  1. in the PR, add the new set of packages in the manifest-lock.overrides.yaml. This will run the -override pipeline which download the RPMs in overrides/rpm c.f. https://gitlab.com/fedora/bootc/tekton-catalog/-/blob/27e2f87bc193815dbd7e7daac0299b3fcefd0b8c/tasks/prepare-build-context/prepare-build-context.yaml#L171
  2. once the PR merged, the packages will be tagged, the classic on-push pipeline will pull it from the repo, and the build will continue
  3. the Remove graduated overrides GH Action will remove them from manifest-lock.overrides.yaml during the next iteration

WDYT ?

@jbtrystram

Copy link
Copy Markdown
Member

WDYT ?

Ah yeah, good idea! Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants