Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains some basic
clippylint fixes that clean a few things up.Some of these fixes are from regular lints in
#[cfg(test)]that only show up if you runcargo clippywith the--all-targetsflag.Other fixes are from some lints in the
pedanticgroup. There are to kinds of fixes here:[lints.clippy]section of theCargo.tomlThere are other warnings from the
pedanticgroup that are either false-positives or more style choices that I didn't bother with.Not really any functional changes and all tests are passing (other than
test-buildtime.shwhich is also failing for me onmain(d861f16) with none of my changes). Planning to look into other things after this PR, but wanted to start with the basics.No AI was used.