Repository navigation
Improve get_efi_vendor() to use Path - #997
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a nice improvement, refactoring get_efi_vendor to use &Path instead of &str for path arguments. This is a good practice in Rust that improves type safety and code clarity. The changes are applied consistently across the trait definition, implementations, and call sites. The test cases are also updated accordingly.
I have one suggestion in src/efi.rs to make the implementation slightly more efficient by avoiding some unnecessary memory allocations. Overall, this is a solid refactoring.
HuijingHei
force-pushed
the
improve-step2-prep
branch
2 times, most recently
from
September 4, 2025 08:16
254a6e3 to
e5247b2
Compare
HuijingHei
force-pushed
the
improve-step2-prep
branch
from
September 4, 2025 08:20
e5247b2 to
59f98b0
Compare
travier
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows #991 (comment)