Skip to content

ci: download the grub-cc binary from Fedora Koji to avoid failures #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rolv-Apneseth merged 1 commit into from
Oct 20, 2026
+18 −24
Merged

ci: download the grub-cc binary from Fedora Koji to avoid failures #1174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 18 additions & 24 deletions Dockerfile.bls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,34 +19,10 @@ RUN --mount=type=cache,target=/build/target --mount=type=cache,target=/var/rooth
make && make install-all DESTDIR=/out


# Get the latest GrubCC binary
FROM quay.io/fedora/eln:latest AS grub-cc-download
RUN --mount=type=tmpfs,target=/run --mount=type=tmpfs,target=/tmp <<EOF
set -eux

# There isn't a generic grub2-efi-cc package that DNF can automatically resolve
case "$(uname -m)" in
x86_64)
dnf download grub2-efi-x64-cc
;;
aarch64)
dnf download grub2-efi-aa64-cc
;;
*)
echo "Unsupported architecture: $(uname -m)" >&2
exit 1
;;
esac

mv ./*.rpm grub-cc.rpm

EOF

FROM $base
# Clean out the default to ensure we're using our updated content
RUN rpm -e bootupd
COPY --from=build /out/ /
COPY --from=grub-cc-download /grub-cc.rpm /var/grub-cc.rpm
# Install bootc from copr
RUN --mount=type=tmpfs,target=/run --mount=type=tmpfs,target=/tmp <<EORUN
set -xeuo pipefail
Expand Down Expand Up @@ -91,6 +67,24 @@ cleanup() {
rm -rvf /var/grub-cc*
}

# HACK: fetch grub-cc from Fedora Koji since there is currently no reliable source for grub-cc.
# NOTE: the referenced build may eventually be garbage collected.

@joelcapitao joelcapitao Oct 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this happens, a solution is to tag the RPM in our coreos-pool Koji tag and then use our mirror link

@Rolv-Apneseth Rolv-Apneseth Oct 20, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good to know, thanks @joelcapitao

@Johan-Liebert1 Johan-Liebert1 Oct 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We hit the same issue in bootc CI and we decided to stop testing GrubCC until it's stable

case "$(uname -m)" in
x86_64)
grub_cc_url=https://kojipkgs.fedoraproject.org/packages/grub2/2.12/60.eln156/x86_64/grub2-efi-x64-cc-2.12-60.eln156.x86_64.rpm
;;
aarch64)
grub_cc_url=https://kojipkgs.fedoraproject.org/packages/grub2/2.12/60.eln156/aarch64/grub2-efi-aa64-cc-2.12-60.eln156.aarch64.rpm
;;
*)
echo "Unsupported architecture: $(uname -m)" >&2
exit 1
;;
esac

curl --fail --location --retry 5 --retry-all-errors --retry-delay 1 \
--output /var/grub-cc.rpm "$grub_cc_url"
Comment thread
coderabbitai[bot] marked this conversation as resolved.

# Extract and install grub-cc at the correct path
mkdir /var/grub-cc
rpm2archive /var/grub-cc.rpm | tar -xvz -C /var/grub-cc
Expand Down
Loading