Repository navigation
ci: Regenerate the initramfs after installing bootc from copr - #1168
Conversation
The CI image replaces the base image's bootc with a newer build from copr but keeps the base image's initramfs, which bootc doesn't support. It broke the stream10 composefs UEFI boot test once bootc started writing only composefs.digest= in BLS entries: the bootc 1.16.13 initramfs in centos-bootc:stream10 only starts bootc-root-setup.service with a composefs= karg, so switch-root fails. Generated-by: AI
|
Hi @cgwalters-bot. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (8)
🔇 Additional comments (1)
📝 WalkthroughWalkthroughThe Dockerfile now regenerates the initramfs after installing ChangesImage build
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The initramfs regeneration has no confirmed merge-blocking issue. The untested image variants remain worth checking through normal CI. 🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (4 passed)
Full details: Commit Message ConventionExplanation The PR has one non-merge commit:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/ok-to-test |
The CI image installs bootc from copr on top of centos-bootc but keeps the base image's initramfs. Current bootc writes only
composefs.digest=in BLS entries, while the bootc 1.16.13 initramfs incentos-bootc:stream10only startsbootc-root-setup.servicewith acomposefskarg, so the composefs UEFI boot test ends in emergency mode (job). A newer bootc with an older initramfs isn't supported, so this regenerates the initramfs after installing bootc.Tested on a 16-core RHEL 10 devspace, with the stream10 image built from
Dockerfile(copr bootc 202609261137.g83d1589142) and rootless equivalents of thebootc-e2esteps (bcvk to-disk --filesystem ext4in place of the privilegedbootc install to-disk --via-loopback, then the same OVMF QEMU boot asscripts/test-uefi-vm-boot.sh):ConditionKernelCommandLine=|composefs.digest(before: only=composefs).login:with this change; on main it fails with "Failed to start initrd-switch-root.service" and enters emergency mode.login:with this change.tests/tests/bootupctl-status-in-bootc.shand the build'sbootc container lint --fatal-warningspass.Not run: the stream9, aarch64 and grubcc=1 (Fedora,
Dockerfile.bls, which doesn't use the copr) variants, and the BIOS boot test.Generated-by: https://github.com/cgwalters/#llms