Skip to content

Remove rpm depency from packagesystem! - #1130

Open
krolmiki2011 wants to merge 13 commits into
coreos:mainfrom
ImmutableLinux:no-rpm-anymore
Open

Remove rpm depency from packagesystem!#1130
krolmiki2011 wants to merge 13 commits into
coreos:mainfrom
ImmutableLinux:no-rpm-anymore

Conversation

@krolmiki2011

@krolmiki2011 krolmiki2011 commented Jul 27, 2026

Copy link
Copy Markdown

Thanks to these changes, it will be possible to eliminate the rpm dependency from bootupd and become more distribution-independent!

KEY CHANGES:
BIOS:
In the case of BIOS, ContentMetadata is created just as it is for UEFI; for BIOS, grub2-install --version and the mtime are used.
EFI (ostree-boot):
The situation is similar for ostree-boot in BIOS mode, except it iterates through files, and the version format is: legacy-ostree-boot-{mtime}

NOTE:
The old code, before the modification, is in the {bios, efi, packagesystem}_legacy.rs

Oh, and 'grub2-install --version' need package maintainers to patch grub2 upstream version to package version

This patch was inspired by issue: #468

Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown

Hi @krolmiki2011. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
@krolmiki2011

Copy link
Copy Markdown
Author

hello can someone help me, because tests not working

@krolmiki2011

Copy link
Copy Markdown
Author

Hello, its anyone here?

@krolmiki2011

Copy link
Copy Markdown
Author

Hello?

@krolmiki2011

Copy link
Copy Markdown
Author

Is there anyone here?

@Rolv-Apneseth

Copy link
Copy Markdown
Member

Hi @krolmiki2011. We have reduced capacity for going through bootupd contributions at the moment, but when I get the chance I'll try to look this over.

From a very brief glance, why keep the legacy code files? Investigating the failing CI will take a more thorough investigation, but it does seem related to these changes. Are we maybe missing something to filter out only bootloader components here?

@Rolv-Apneseth

Copy link
Copy Markdown
Member

One more point, though again it may just require a deeper look from my part, but #468 (comment) would lead me to believe this should be possible without making changes to files other than packagesystem.rs. Could you give a brief explanation of why that wasn't possible for this approach?

@krolmiki2011

Copy link
Copy Markdown
Author

One more point, though again it may just require a deeper look from my part, but #468 (comment) would lead me to believe this should be possible without making changes to files other than packagesystem.rs. Could you give a brief explanation of why that wasn't possible for this approach?

Okay, so I view this notebook as a place to keep things in case the code turns into spaghetti, but also as something to delete once the code is stable.

Regarding your second question—a good point—I noticed that BIOS and Legacy EFI (OSTree boot) both use RPM; while BIOS is handled by query_bios_grub() in packagesystem.rs, Legacy EFI isn't. I could certainly implement a similar function in packagesystem if you'd like.

Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants