Remove rpm depency from packagesystem! - #1130
Conversation
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
|
Hi @krolmiki2011. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
|
hello can someone help me, because tests not working |
|
Hello, its anyone here? |
|
Hello? |
|
Is there anyone here? |
|
Hi @krolmiki2011. We have reduced capacity for going through From a very brief glance, why keep the legacy code files? Investigating the failing CI will take a more thorough investigation, but it does seem related to these changes. Are we maybe missing something to filter out only bootloader components here? |
|
One more point, though again it may just require a deeper look from my part, but #468 (comment) would lead me to believe this should be possible without making changes to files other than |
Okay, so I view this notebook as a place to keep things in case the code turns into spaghetti, but also as something to delete once the code is stable. Regarding your second question—a good point—I noticed that BIOS and Legacy EFI (OSTree boot) both use RPM; while BIOS is handled by |
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Thanks to these changes, it will be possible to eliminate the rpm dependency from bootupd and become more distribution-independent!
KEY CHANGES:
BIOS:
In the case of BIOS, ContentMetadata is created just as it is for UEFI; for BIOS,
grub2-install --versionand themtimeare used.EFI (ostree-boot):
The situation is similar for ostree-boot in BIOS mode, except it iterates through files, and the version format is: legacy-ostree-boot-{mtime}
NOTE:
The old code, before the modification, is in the {bios, efi, packagesystem}_legacy.rs
Oh, and 'grub2-install --version' need package maintainers to patch grub2 upstream version to package version
This patch was inspired by issue: #468