Skip to content

Embed google recaptcha#1003

Open
manvikhatri123 wants to merge 2 commits into
devfrom
feature/Embed_google_recaptcha
Open

Embed google recaptcha#1003
manvikhatri123 wants to merge 2 commits into
devfrom
feature/Embed_google_recaptcha

Conversation

@manvikhatri123

Copy link
Copy Markdown
Member

No description provided.

Comment thread users/views.py Outdated
data={
"secret": settings.RECAPTCHA_SECRET_KEY,
"response": token,
},

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No logger written. IF anything goes wrong how we will track this. Please write logger for troubleshoot in proper format

Comment thread users/views.py
# Call parent class method to validate credentials and get tokens
response = super().post(request, *args, **kwargs)
captcha_token = request.data.get("captcha")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issuw write logger

@kapildadheech kapildadheech left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write proper logger. If anything goes wrong how we can track the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants