Wire chip type selection (AY / YM) through GUI menu, toolbar, status bar, and CLI - #52
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/corbym/vtir/sessions/8caeefa5-4170-4c16-ac96-eeb10d850e16 Co-authored-by: corbym <21261837+corbym@users.noreply.github.com>
Agent-Logs-Url: https://github.com/corbym/vtir/sessions/8caeefa5-4170-4c16-ac96-eeb10d850e16 Co-authored-by: corbym <21261837+corbym@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
corbym
April 22, 2026 06:26
View session
Owner
|
Remove native builds except web from pr workflows and keep them only in main build |
Owner
|
@copilot Remove native builds except web from pr workflows and keep them only in main build |
Agent-Logs-Url: https://github.com/corbym/vtir/sessions/fadf1a2d-616b-4b00-9ff3-97757dd8e977 Co-authored-by: corbym <21261837+corbym@users.noreply.github.com>
Contributor
Author
Done in 4df3a77. Added |
Contributor
🚀 WASM PreviewA live preview of this PR's WASM build is available at: https://corbym.github.io/vtir/pr-previews/52/ Last updated: Wed, 22 Apr 2026 06:31:32 GMT |
corbym
marked this pull request as ready for review
April 22, 2026 17:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports Pascal's
SetEmulatingChip/ToggleChipExecute/Calculate_Level_Tableschain to Rust, making the AY↔YM chip model selectable at runtime with immediate audible effect.Core changes
Synthesizer::set_chip_type(ChipType)— rebuilds amplitude level tables in-place without tearing down the synth; mirrorsPlaybackBufferMaker.Calculate_Level_Tablesindigsoundbuf.pasVortexTrackerApp::chip_type— single authoritative field (defaultAY), mirroringVTOptions.ChipType;set_emulating_chip()updates it and callsset_chip_type;rebuild_synth_for_modulesnow respects it instead of hard-coding AYOptionsmenu — adds AY / YM radio items, mirrorsTOptionsDlg.ChipSelClickTBChip/ToggleChipExecute; label shows current chipAYorYMchip label, mirrorsToggleChip.CaptionChipType::Noneisunreachable!()in all UI/CLI paths — was previously rendered as the silent string"?"CLI parity
--chip-type ay|ymflag (default:ay) wired all the way throughCliArgs→CliTracker::load; previously the parsed value was dropped at the call siteckey binding cycles chip type at runtime;toggle_monopreserves current chip type when rebuilding the synthchip_type=AY|YM; usage string documents the new flag and key