Handle ZeroSized constants in const_value_ty#96
Merged
Conversation
ZST struct instances (e.g. `struct Counter;`) are represented in optimized MIR as `ConstValue::ZeroSized`. The `const_value_ty` function had no case for this variant, causing an ICE whenever such a constant appeared as a function argument or operand. Add a catch-all `ConstValue::ZeroSized` arm that returns a unit PlaceType (empty tuple), matching the existing treatment of empty- tuple and zero-upvar-closure constants. Also add a UI regression test for the two reproducers from issue #72. Fixes #72. https://claude.ai/code/session_01M4BtRPcV7cZxTsasLbGjxs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apparently, #72 is fixed by #90