Repository navigation
Report a failed paginated query page to its own subscribers - #208
Open
stickerdaniel wants to merge 1 commit into
Open
stickerdaniel wants to merge 1 commit into
stickerdaniel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #193.
When one page of a paginated query fails,
PaginatedQueryClient.onBaseTransitionreads it while building the transition and throws. Nothing is delivered: theonErrorofonPaginatedUpdate_experimentalnever runs, and every later transition throws the same way.ConvexReactClientroutes all transitions through the paginated client, so once a page ofusePaginatedQuery_experimentalfails, everyuseQueryin the app stops updating.onBaseTransitionhandles each paginated query on its own and reports a failure as a newFailedmodification for that query only.localQueryResultByTokenalso reads the pages of an ongoing split, so a failed half surfaces while the other half is still loading.ConvexClientno longer reads a paginated result outside thetrythat callsonError, neither to check readiness nor when a subscriber registers.loadMoreon a failed query still throws at the caller. I left that out to keep this focused.The new tests drive the real
ConvexClientandConvexReactClientoverwithInMemoryWebSocket. All five fail onmainand pass with this change.Implemented with Claude Opus 5.5 (xhigh) and reviewed with GPT-6 (Extra High) in Claude Code via T3 Code.