Repository navigation
cli: use "in 1 day" in deployment create --expiration help examples - #205
Open
CloudCorpRecords wants to merge 1 commit into
Open
CloudCorpRecords wants to merge 1 commit into
CloudCorpRecords wants to merge 1 commit into
Conversation
The help text for `convex deployment create --expiration` and the expiration parse-error message both used "in 7 days" as the relative example, but the Cloud create-deployment API rejects expirations more than 5 days in the future (InvalidExpiresAt, per convex#196). Use "in 1 day" in both examples so the documented example is directly usable for the dev-deployment creation flow. Signed-off-by: Rene Turcios <95189389+CloudCorpRecords@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the limit is
The Cloud
create-deploymentAPI rejects expirations more than 5 days in the future (HTTP 400 InvalidExpiresAt: expiresAt cannot be more than 5 days in the future), as documented in #196.What changed
The
--expirationhelp example forconvex deployment create(and the expiration parse-error message) used"in 7 days"as the relative example, which the API rejects. This PR changes both examples to"in 1 day", comfortably inside the observed five-day maximum, as proposed in the issue.Files:
src/cli/deploymentCreate.ts—--expiration <value>option help textsrc/cli/lib/expiration.ts—PARSE_ERROR_MESSAGErelative-format exampleHelp text only;
parseExpiration/validateExpirationbehavior is unchanged. No client-side validation rule was added, since limits may differ by deployment type or account (per the issue's proposal).Evidence
upstream/main:deploymentCreate.ts:81andexpiration.ts:13both said"in 7 days"before this change.git diffon the two files shows only the example swap.src/cli/network_test.tsexists undersrc/cli/, unrelated), so nothing to update.Honest limits
npm testsuite in this environment (integration/e2e coverage lives outside this repo anyway per CONTRIBUTING.md), but this change touches only help strings and cannot affect runtime behavior.Fixes #196.