Repository navigation
Move the session and TTL helpers out of public.ts #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dowski
wants to merge
1
commit into
dowski/compute-refresh-token-expiry
Choose a base branch
from
dowski/session-helpers
base: dowski/compute-refresh-token-expiry
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| // Token lifetimes: the validated config of a call, and when a refresh token | ||
| // expires under it. | ||
|
|
||
| import type { Doc } from "./_generated/dataModel.ts"; | ||
| import { | ||
| DEFAULT_ACCESS_TOKEN_TTL_SECONDS, | ||
| DEFAULT_REFRESH_TOKEN_TTL_SECONDS, | ||
| } from "../lib/ttl.ts"; | ||
|
|
||
| // `ctx.auth.signJwt` refuses to mint a token that lives longer than an hour, | ||
| // so an access-token TTL past that is a misconfiguration. | ||
| const MAX_ACCESS_TOKEN_TTL_SECONDS = 60 * 60; // 1 hour | ||
|
|
||
| /** | ||
| * The token lifetimes for a call, with the app's overrides applied over the | ||
| * defaults. Validated so a misconfiguration fails loudly rather than minting | ||
| * nonsensical sessions. | ||
| */ | ||
| export type TtlConfig = { | ||
| accessTokenTtlSeconds: number; | ||
| refreshTokenTtlSeconds: number; | ||
| }; | ||
|
|
||
| export function resolveTtlConfig(args: { | ||
| accessTokenTtlSeconds?: number; | ||
| refreshTokenTtlSeconds?: number; | ||
| }): TtlConfig { | ||
| const accessTokenTtlSeconds = | ||
| args.accessTokenTtlSeconds ?? DEFAULT_ACCESS_TOKEN_TTL_SECONDS; | ||
| const refreshTokenTtlSeconds = | ||
| args.refreshTokenTtlSeconds ?? DEFAULT_REFRESH_TOKEN_TTL_SECONDS; | ||
| if (accessTokenTtlSeconds <= 0 || refreshTokenTtlSeconds <= 0) { | ||
| throw new Error("Token TTLs must be positive."); | ||
| } | ||
| if (accessTokenTtlSeconds > MAX_ACCESS_TOKEN_TTL_SECONDS) { | ||
| throw new Error( | ||
| "Access-token TTL must be at most one hour (the deployment refuses " + | ||
| "to sign a longer-lived JWT).", | ||
| ); | ||
| } | ||
| if (accessTokenTtlSeconds >= refreshTokenTtlSeconds) { | ||
| throw new Error( | ||
| "Access-token TTL must be shorter than the refresh-token TTL.", | ||
| ); | ||
| } | ||
| return { accessTokenTtlSeconds, refreshTokenTtlSeconds }; | ||
| } | ||
|
|
||
| /** | ||
| * When a refresh token expires under the given refresh-token TTL. | ||
| * | ||
| * Expiry is derived rather than stored, so a changed TTL applies to every | ||
| * outstanding token. It also means a session's newest token is always its | ||
| * last to expire. | ||
| */ | ||
| export function refreshTokenExpiresAt( | ||
| token: Pick<Doc<"refreshTokens">, "_creationTime">, | ||
| refreshTokenTtlSeconds: number, | ||
| ): number { | ||
| return token._creationTime + refreshTokenTtlSeconds * 1000; | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2:
NaNandInfinitypass this check, and a non-finite refresh TTL makes the refresh expiry comparison always false. Reject non-finite TTLs here withNumber.isFiniteso misconfiguration cannot create non-expiring sessions.Prompt for AI agents