Skip to content

updated createGvc validation #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobecox merged 2 commits into from
Apr 14, 2026
Merged

updated createGvc validation #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4f2fa8
updated createGvc validation
jacobecox Apr 14, 2026
81cba8c
added gha exception for libary templates
jacobecox Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/validate-charts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,12 @@ jobs:
local template=$(echo "$version_dir" | cut -d/ -f1)
local version=$(grep '^version:' "$version_dir/Chart.yaml" | awk '{print $2}')

# Library charts cannot be rendered standalone — skip helm template validation
if grep -qE '^\s*type:\s*library' "$version_dir/Chart.yaml"; then
echo "Skipping $template @ $version (library chart)"
return
fi

echo ""
echo "=== Validating $template @ $version ==="

Expand Down
2 changes: 1 addition & 1 deletion cpln-common/versions/1.0.0/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ app.cpln.io/managed-by: {{ .Release.Service }}
cpln/marketplace: "true"
cpln/marketplace-template: {{ .Chart.Name }}
cpln/marketplace-template-version: {{ .Chart.Version }}
{{- if .Values.global.cpln.gvc }}
{{- if dig "global" "cpln" "gvc" "" .Values }}
cpln/marketplace-gvc: {{ .Values.global.cpln.gvc }}
{{- end }}
{{- end }}
Loading