Skip to content

fix(core): honor config requestOptions in ContinueServerClient#12966

Open
wuisabel-gif wants to merge 1 commit into
continuedev:mainfrom
wuisabel-gif:fix/continue-server-client-request-options
Open

fix(core): honor config requestOptions in ContinueServerClient#12966
wuisabel-gif wants to merge 1 commit into
continuedev:mainfrom
wuisabel-gif:fix/continue-server-client-request-options

Conversation

@wuisabel-gif

Copy link
Copy Markdown

Description

Config-sync and index-cache requests in ContinueServerClient used the global fetch(), so config.yaml requestOptions (proxy, verifySsl, caBundlePath) were ignored on those paths. Behind an HTTPS-intercepting corporate proxy with a custom CA, this surfaces as a startup "Connection error" in core.log even though LLM requests work fine (they already go through fetchwithRequestOptions).

This routes the client's requests through fetchwithRequestOptions and passes config.requestOptions in from CodebaseIndexer, so the same proxy/TLS settings apply to config sync and index caching.

Fixes #12956

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screen recording or screenshot

N/A — network-path change with no UI. Any request made by ContinueServerClient previously bypassed config.yaml requestOptions; after this change it uses them.

Tests

Added core/continueServer/stubs/client.vitest.ts — verifies getConfig and getFromIndexCache forward the constructor's requestOptions to fetchwithRequestOptions.

@wuisabel-gif wuisabel-gif requested a review from a team as a code owner July 10, 2026 02:13
@wuisabel-gif wuisabel-gif requested review from sestinj and removed request for a team July 10, 2026 02:13
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@wuisabel-gif

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA.

Config-sync and index-cache requests used global fetch(), ignoring
config.yaml requestOptions (proxy, verifySsl, caBundlePath). Route them
through fetchwithRequestOptions like the LLM path already does.

Fixes continuedev#12956
@wuisabel-gif wuisabel-gif force-pushed the fix/continue-server-client-request-options branch from 7703b56 to 259a6e4 Compare July 10, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proxy and VerifySsl settings in config.yml are ignored by node.js process

1 participant