build: Style fix#1802
Conversation
containers#1801 Signed-off-by: Ferenc Géczi <ferenc.gm@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the go-build-wrapper script to correct the syntax for passing the --unresolved-symbols option to the linker via -Wl, changing the separator from = to ,. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Use a comma to pass an argument to an external linker option instead of an equal sign for consistency. It was originally copied verbatim from the NVIDIA Container Toolkit [1], which itself has this inconsistency. Fallout from 66280a6 [1] NVIDIA Container Toolkit commit 772cf77dcc2347ce NVIDIA/nvidia-container-toolkit@772cf77dcc2347ce NVIDIA/nvidia-container-toolkit#333 containers#1802
debarshiray
force-pushed
the
wip/rishi/src-go-build-wrapper-extldflags-use-comma-not-equal
branch
from
def89d8 to
730326c
Compare
Use a comma to pass an argument to an external linker flag instead of an equal sign for consistency. It was originally copied verbatim from the NVIDIA Container Toolkit [1], which itself has this inconsistency. Fallout from 66280a6 [1] NVIDIA Container Toolkit commit 772cf77dcc2347ce NVIDIA/nvidia-container-toolkit@772cf77dcc2347ce NVIDIA/nvidia-container-toolkit#333 containers#1802
debarshiray
force-pushed
the
wip/rishi/src-go-build-wrapper-extldflags-use-comma-not-equal
branch
from
730326c to
ebee6ab
Compare
Fallout from 66280a6 containers#1802
|
recheck |
It's the same failure that we have been seeing lately: It looks like it's stuck downloading and caching the OCI images used by the test suite during the set-up stage. Everything was fine on the 28th of May. The Initially, I thought that it was some passing problem with the infrastructure or Fedora Rawhide, and then the Fedora 44 failures started. @TristanCacqueray any idea off the top of your head what could be wrong? Otherwise, I will dig deeper into it by enabling some extra debug. |
debarshiray
deleted the
wip/rishi/src-go-build-wrapper-extldflags-use-comma-not-equal
branch
|
@debarshiray in success build, it takes 44 second for the bats command to display the first result, so it's not clear what's going on. As a first step, we can add some debug flags to see what's happening when the TIMED_OUT occur, e.g. from the job-output.txt: … timed out: Let's see if #1805 will shed some light. |
3 participants
Use a comma to pass an argument to an external linker option instead of an equal sign for consistency. It was originally copied verbatim from the NVIDIA Container Toolkit [1], which itself has this inconsistency.
Fallout from 66280a6
[1] NVIDIA Container Toolkit commit 772cf77dcc2347ce
NVIDIA/nvidia-container-toolkit@772cf77dcc2347ce
NVIDIA/nvidia-container-toolkit#333