Wire WorkDir into runc command invocation#114
Open
cpuguy83 wants to merge 1 commit into
Open
Conversation
WorkDir sets the working directory of the invoked runc process, applied on both the Linux and non-Linux command paths. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using go-runc in github.com/cpuguy83/containerd-shim-systemd-v1 and to make some of the containerd integration tests pass on the shim I need runc to execute in the bundle root, but go-runc didn't really provide a good way to do that, which means either dealing with re-exec or some unshare/chdir logic.