exec:support to set custom log path

[ningmingxiao]

I create a pr containerd/containerd#11862 to address containerd/containerd#8972
I want to specify runc log to custom path when exec .

[ningmingxiao]

ping @fuweid @AkihiroSuda @mikebrow can you review this pr thanks?

[mikebrow]

LGTM

[ningmingxiao]

thank you

[ningmingxiao]

ping @fuweid

[ningmingxiao]

@thaJeztah can you review this pr? docker may have same issue.

[ningmingxiao]

‌PTAL‌ @dmcgowan try to fix containerd/containerd#8972

[thaJeztah]

Looks like this PR will auto-close the containerd issue because the PR description has "to fix <ticket>"

Can someone with permissions edit the description to remove that part (change it to "to address")?

[ningmingxiao]

Looks like this PR will auto-close the containerd issue because the PR description has "to fix <ticket>"

Can someone with permissions edit the description to remove that part (change it to "to address")?

done

[thaJeztah]

Thx! Commented from my phone, and didn't review yet, but thought I'd comment before github got trigger happy and close the ticket pre-maturely ☺️

[Copilot]

Pull request overview

This PR adds support for overriding the runc --log path specifically for exec calls, enabling a per-exec log destination without changing the global Runc.Log setting.

Changes:

• Add ExecOpts.LogFile and wire it into Exec() so runc can be invoked with a custom --log path for exec.
• Refactor command construction to support an optional log override (via commandWithCustomLogFile and args(logFile)).
• Add a unit test for log-override argument behavior and pin containerd/project-checks to a specific commit in CI.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
runc.go	Adds ExecOpts.LogFile, routes Exec() through a log-override capable command path, and updates global arg construction to accept an override.
command_linux.go	Introduces commandWithCustomLogFile and passes the override into r.args(logFile) on Linux.
command_other.go	Introduces commandWithCustomLogFile and passes the override into r.args(logFile) on non-Linux platforms.
runc_test.go	Adds a test around log-file override behavior for argument construction.
.github/workflows/ci.yml	Pins containerd/project-checks to a specific commit (annotated as v1.2.2).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ningmingxiao]

done thanks @samuelkarp

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

[ningmingxiao]

done @samuelkarp

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

[ningmingxiao]

can this pr be merged @samuelkarp ?

[samuelkarp]

@mikebrow can you re-review since it's been a year since your last approval?

[mikebrow]

LGTM

[ningmingxiao]

ping @samuelkarp