fix: add ShutdownTimeout to SatelliteOptions struct

[Dishank-Sen]

• Fixes: refactor(satellite): move shutdownTimeout to SatelliteOptions for consistency #604

Description

Moves shutdownTimeout into the SatelliteOptions struct for consistency with all other CLI flags and environment variables.

Changes:

• Added ShutdownTimeout field to SatelliteOptions struct (line 61)
• Initialized from envCfg.ShutdownTimeout in main() (line 87)
• Updated flag binding to use opts.ShutdownTimeout (line 104)
• Removed separate shutdownTimeout variable
• Simplified run() function signature from 3 to 2 parameters (line 253, 163)
• Passed opts.ShutdownTimeout to gracefulShutdown() (line 435)

Impact:
This is a pure refactoring with no functional changes. All 16 configuration values now follow the same pattern, making the codebase more consistent and maintainable.

Testing:

• Code compiles successfully
• All unit tests pass
• CLI flag --shutdown-timeout works correctly with default value of 30s

Additional context

This inconsistency was introduced during the env package refactor (commit a3a6145, PR #514) where ShutdownTimeout was added to env.HarborSatellite but not migrated to SatelliteOptions like other fields.

The change actually reduces complexity by removing a parameter from run() while maintaining identical behavior.

Summary by CodeRabbit

• New Features

  • Added a configurable shutdown timeout for graceful application shutdown.
  • The timeout can be set through environment configuration or the --shutdown-timeout command-line option.

• Improvements

  • Shutdown behavior now consistently uses the configured timeout value.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 90616bed-a26d-461d-b62e-f37b19a85cdd

📥 Commits

Reviewing files that changed from the base of the PR and between 341cb42 and c91acd8.

📒 Files selected for processing (1)

• cmd/satellite/main.go

---

📝 Walkthrough

Walkthrough

The satellite now stores shutdown timeout in SatelliteOptions. Environment configuration and the CLI flag populate this field. run uses the options value for graceful shutdown.

Changes

Satellite shutdown timeout refactor

Layer / File(s)	Summary
Shutdown timeout option configuration cmd/satellite/main.go	Adds SatelliteOptions.ShutdownTimeout, initializes it from environment configuration, and binds --shutdown-timeout directly to the option.
Run and graceful shutdown propagation cmd/satellite/main.go	Removes the standalone run timeout parameter and passes opts.ShutdownTimeout to graceful shutdown.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• container-registry/harbor-satellite#258: Introduced the shutdown-timeout handling that this refactor reorganizes.

Suggested reviewers: vg006

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: adding ShutdownTimeout to SatelliteOptions.
Description check	✅ Passed	The description includes the issue reference, change summary, impact, testing details, and additional context.
Linked Issues check	✅ Passed	The changes satisfy issue #604 by moving ShutdownTimeout into SatelliteOptions and simplifying run() to two parameters.
Out of Scope Changes check	✅ Passed	The changes are limited to the requested shutdown-timeout refactoring and related parameter updates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gitar-bot]

Gitar is working

_Gitar

[codacy-production]

Not up to standards ⛔

🔴 Issues 2 medium

Alerts:
⚠ 2 issues (≤ 0 issues of at least minor severity)

Results:
2 new issues

Category	Results
Complexity	2 medium

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric	Results
Complexity	0
Duplication	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[cubic-dev-ai]

No issues found across 1 file

_{Re-trigger cubic}

[Dishank-Sen]

@vg006 There is some issue with Codacy, can you help me out.

[vg006]

Not a big issue, it usually complaints on code standards like line of codes, cyclomatic complexity.

But I reviewed your PR and LGTM.