chore(deps): bump ort rc.10 → rc.13 and ndarray 0.16 → 0.17 (supersedes #150 and #152) - #195
Open
Teagan42 wants to merge 1 commit into
Open
chore(deps): bump ort rc.10 → rc.13 and ndarray 0.16 → 0.17 (supersedes #150 and #152)#195Teagan42 wants to merge 1 commit into
Teagan42 wants to merge 1 commit into
Conversation
Supersedes #150 (patch-and-minor group) and #152 (ndarray). These two dependency bumps had to move together: ort rc.13's Tensor API is generic over the OwnedTensorArrayData trait that only ndarray 0.17 implements, and ort rc.13 is what's needed for base64 0.23.1 (the other member of the patch-and-minor group) to resolve cleanly. Code changes in conduit-vad/src/onnx.rs: - Session::builder() chain rewritten. ort rc.13 parameterises the builder-step error type by builder state, so chaining with and_then on a single Result<SessionBuilder> no longer type-checks. Threading each step through ? in a closure keeps behaviour identical. - Tensor::from_array calls unchanged: they now pick up the ndarray 0.17 trait impl automatically. Test plan: - cargo check --workspace: clean. - cargo test -p conduit-vad --features onnx: 6/6 pass. - cargo test -p conduit-wake --features onnx: 6/6 pass. - cargo fmt --all --check: clean. - cargo clippy -p conduit-vad --features onnx -- -D warnings: clean. Closes #150. Closes #152.
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the two dependency bumps that had to move together:
Individually they don't build: `ort` rc.13's `Tensor::from_array` is generic over `OwnedTensorArrayData`, whose impl for owned arrays lives on ndarray 0.17. Bumping ort alone (#150) fails to compile `conduit-vad`; bumping ndarray alone (#152) fails the same way from the other direction.
Doing them together compiles and tests clean.
Code change
One arm of `conduit-vad::onnx` needed fixing: `Session::builder()` in ort rc.13 parameterises each builder step's error type by builder state, so chaining with `and_then` on a single `Result` no longer type-checks. Rewriting the chain through `?` in a closure keeps behaviour identical.
`Tensor::from_array` call sites in `conduit-vad` are unchanged — they pick up ndarray 0.17's trait impl automatically.
Test plan
Closes #150. Closes #152.