fix(codegen): emit INPUT_OBJECT types nested inside CRUD entity inputs#1286
Merged
Conversation
When a table's Create/Patch entity input contains fields referencing non-scalar INPUT_OBJECT types (e.g. requiredConfigs: [FunctionRequirementInput]), the ORM input-types generator would inline the type name as a string but never generate its interface definition. This caused TypeScript build failures in downstream SDK packages. Root cause: collectInputTypeNames only scanned operation args and table field args, not the fields inside CRUD entity input types (CreateXInput → XInput → nested input types). Fix: adds collectCrudNestedInputTypes() which traverses Create/Patch entity input fields recursively and collects any referenced INPUT_OBJECT types, merging them into the custom input types generation pass. Adds two tests covering the collection and full output generation.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a codegen bug where
INPUT_OBJECTtypes referenced by CRUD entity input fields were never emitted ininput-types.ts, causing downstream TypeScript build failures.Example:
PlatformFunctionDefinitionhasrequiredConfigs: [FunctionRequirementInput]. The CRUD generator inlines this as a type string inCreatePlatformFunctionDefinitionInput, butFunctionRequirementInputwas never generated as an interface — onlyFunctionRequirementwas emitted astype FunctionRequirement = unknown(custom scalar alias).Root cause in
generateInputTypesFile:collectInputTypeNamesonly scans operation args and table field args. The CRUD path (buildCreateDataFieldsFromSchema) reads entity input fields viatypeRefToTs→ returns type name strings, but nobody collects those referenced input types for generation.New
collectCrudNestedInputTypes()walks each table'sCreate*Inputand*Patchentity input fields, recursively collecting anyINPUT_OBJECTtypes found. These are merged intomergedUsedInputTypessogenerateCustomInputTypesemits them.All 358 existing tests pass + 2 new tests covering collection and full output generation.
Link to Devin session: https://app.devin.ai/sessions/b2291a8e333e445aa125a2efd1996206
Requested by: @pyramation