Fix test compile: String.write is no longer a static method - #6
Merged
Conversation
Mojo's stdlib made String.write an instance method -- both overloads now take `mut self` -- so the old static form no longer resolves and the test module fails to parse. String.__init__ takes a variadic pack of Writable arguments and Error conforms to Writable, so String(e) is the direct replacement. Test-only; nothing in src/ used the static form. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testworkflow has been red onmainsince a Mojo nightly bump between 7/29 and 7/31, with no source change to cause it. The stdlib madeString.writean instance method, so both overloads now takemut selfand the old static call no longer resolves:String.__init__takes a variadic pack ofWritableargs andErrorconforms toWritable, soString(e)is the direct replacement and writes the same bytes. Verified green in CI on conorbronsdon/mojo-feed#5 before replicating here.Test-only; nothing in
src/used the static form.Root cause, worth a separate look: the workflow installs
mojofrom the nightly index with--prerelease allowand no version pin, so each run resolves whatever nightly is current. That is why a frozen repo went green → red with no commits between.🤖 Generated with Claude Code