Fix Clang CFI icall type mismatch in rd_list_remove_cmp and string comparators

src/rdkafka_cgrp.c

@@ -3045,8 +3045,7 @@ rd_kafka_cgrp_consumer_assignment_with_metadata(
                              rd_kafka_Uuid_base64str(&request_topic_id));
         }
         if (missing_topic_ids && *missing_topic_ids)
-                rd_list_deduplicate(missing_topic_ids,
-                                    (void *)rd_kafka_Uuid_ptr_cmp);
+                rd_list_deduplicate(missing_topic_ids, rd_kafka_Uuid_ptr_cmp);
         return assignment_with_metadata;
 }
 

src/rdkafka_metadata.c

@@ -951,13 +951,13 @@ rd_kafka_parse_Metadata0(rd_kafka_broker_t *rkb,
                         rd_list_free_cb(missing_topics,
                                         rd_list_remove_cmp(missing_topics,
                                                            md->topics[i].topic,
-                                                           (void *)strcmp));
+                                                           rd_list_cmp_str));
                 if (requested_topic_ids)
                         rd_list_free_cb(
                             missing_topic_ids,
                             rd_list_remove_cmp(missing_topic_ids,
                                                &mdi->topics[i].topic_id,
-                                               (void *)rd_kafka_Uuid_ptr_cmp));
+                                               rd_kafka_Uuid_ptr_cmp));
                 /* Only update cache when not asking
                  * for all topics or cache entry
                  * already exists. */

src/rdkafka_partition.c

@@ -3940,7 +3940,7 @@ static rd_bool_t rd_kafka_topic_partition_list_get_leaders(
                         rktpar->err = RD_KAFKA_RESP_ERR__IN_PROGRESS;
                         if (query_topics &&
                             !rd_list_find(query_topics, rktpar->topic,
-                                          (void *)strcmp))
+                                          rd_list_cmp_str))
                                 rd_list_add(query_topics,
                                             rd_strdup(rktpar->topic));
                         continue;
@@ -4372,7 +4372,7 @@ int rd_kafka_topic_partition_list_get_topic_names(
                 if (!include_regex && *rktpar->topic == '^')
                         continue;
 
-                if (!rd_list_find(topics, rktpar->topic, (void *)strcmp)) {
+                if (!rd_list_find(topics, rktpar->topic, rd_list_cmp_str)) {
                         rd_list_add(topics, rd_strdup(rktpar->topic));
                         cnt++;
                 }

src/rdkafka_proto.h

@@ -619,8 +619,9 @@ static RD_INLINE RD_UNUSED int rd_kafka_Uuid_cmp(rd_kafka_Uuid_t a,
         return 0;
 }
 
-static RD_INLINE RD_UNUSED int rd_kafka_Uuid_ptr_cmp(void *a, void *b) {
-        rd_kafka_Uuid_t *a_uuid = a, *b_uuid = b;
+static RD_INLINE RD_UNUSED int rd_kafka_Uuid_ptr_cmp(const void *a,
+                                                     const void *b) {
+        const rd_kafka_Uuid_t *a_uuid = a, *b_uuid = b;
         return rd_kafka_Uuid_cmp(*a_uuid, *b_uuid);
 }
 

src/rdkafka_sasl_oauthbearer.c

@@ -774,7 +774,7 @@ static char *create_jws_compact_serialization(
                                 ++curr;
                         }
 
-                        if (!rd_list_find(&scope, start, (void *)strcmp))
+                        if (!rd_list_find(&scope, start, rd_list_cmp_str))
                                 rd_list_add(&scope, rd_strdup(start));
 
                         if (scope_json_length == 0) {

src/rdkafka_topic.c

@@ -2021,7 +2021,7 @@ void rd_kafka_topic_scan_all(rd_kafka_t *rk, rd_ts_t now) {
                 /* Need to re-query this topic's leader. */
                 if (query_this &&
                     !rd_list_find(&query_topics, rkt->rkt_topic->str,
-                                  (void *)strcmp))
+                                  rd_list_cmp_str))
                         rd_list_add(&query_topics,
                                     rd_strdup(rkt->rkt_topic->str));
         }

src/rdlist.c

@@ -194,7 +194,7 @@ void *rd_list_remove(rd_list_t *rl, void *match_elem) {
 
 void *rd_list_remove_cmp(rd_list_t *rl,
                          void *match_elem,
-                         int (*cmp)(void *_a, void *_b)) {
+                         int (*cmp)(const void *_a, const void *_b)) {
         void *elem;
         int i;
 
@@ -211,7 +211,7 @@ void *rd_list_remove_cmp(rd_list_t *rl,
 
 int rd_list_remove_multi_cmp(rd_list_t *rl,
                              void *match_elem,
-                             int (*cmp)(void *_a, void *_b)) {
+                             int (*cmp)(const void *_a, const void *_b)) {
 
         void *elem;
         int i;

src/rdlist.h

@@ -161,7 +161,7 @@ void *rd_list_remove(rd_list_t *rl, void *match_elem);
  */
 void *rd_list_remove_cmp(rd_list_t *rl,
                          void *match_elem,
-                         int (*cmp)(void *_a, void *_b));
+                         int (*cmp)(const void *_a, const void *_b));
 
 
 /**
@@ -188,7 +188,7 @@ void *rd_list_pop(rd_list_t *rl);
  */
 int rd_list_remove_multi_cmp(rd_list_t *rl,
                              void *match_elem,
-                             int (*cmp)(void *_a, void *_b));
+                             int (*cmp)(const void *_a, const void *_b));
 
 
 /**