Skip to content

[KIP-932] Reject out-of-range AcquiredRecords in share fetch reply #5532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kartik (sage-mode-hunter) wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[KIP-932] Reject out-of-range AcquiredRecords in share fetch reply #5532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/rdkafka_fetcher.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1522,6 +1522,23 @@ static rd_kafka_resp_err_t rd_kafka_share_fetch_reply_handle_partition(

size = LastOffsets[i] - FirstOffsets[i] + 1;

/* size is used both as the int64 fill-loop bound below
* and, truncated to the int32 types_cnt, as the
* allocation count in
* rd_kafka_share_ack_batch_entry_new. A broker-supplied
* range with LastOffset < FirstOffset, or one wider
* than INT32_MAX, would make the truncated allocation
* smaller than the loop bound and overflow
* entry->types. */
if (unlikely(size <= 0 || size > INT32_MAX))
rd_kafka_buf_parse_fail(
rkbuf,
"%.*s [%" PRId32
"]: AcquiredRecords range %" PRId64
"..%" PRId64 " out of range",
RD_KAFKAP_STR_PR(topic), PartitionId,
FirstOffsets[i], LastOffsets[i]);

rd_rkb_dbg(rkb, FETCH, "SHAREFETCH",
"%.*s [%" PRId32
"]: Acquired Records from offset %" PRId64
Expand Down