Repository navigation
fix: restore factory storage, pause and governance modules and repair… - #863
Merged
Jaydbrown merged 2 commits intoOct 31, 2026
Merged
Conversation
… stream build Commit 5ffa7db replaced factory storage.rs, pause.rs and governance.rs with stub lines, which left the factory crate unbuildable. Restore them from the parent commit. Also fix build errors that blocked the workspace: use Symbol::new for the 14-character pfee_collected topic, shorten the stream keeper event symbols to 9 characters, add the missing InvoiceMetadataUri and MilestoneMetadataUri DataKey variants, and add voting_period_ledgers to the factory governance test config. Refs conduit-protocol#820
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit 5ffa7db replaced
contracts/factory/src/storage.rs,pause.rsandgovernance.rswith single stub lines (@storage.rsetc.). The factory crate has not compiled since, anddrip-streamhas separate build errors. This PR repairs both.Changes
pfee_collectedevent topic is 14 characters, over the 9-charactersymbol_short!limit. It now usesSymbol::new, with the same topic name.voting_period_ledgersfield to the governance test config.keeper_cfgandkeeper_fndevent symbols tokeepercfgandkeeperfnd. This changes the emitted topic names, so any indexer or client listening for the old names needs updating.InvoiceMetadataUriandMilestoneMetadataUrivariants toDataKey, whichlib.rsalready uses.Tests
cargo test -p drip-factory --libpasses (53 passed, 2 ignored).cargo test -p drip-stream --lib: 148 passed, 1 failed (math::tests::test_rate_duration_saturating_overflow_behavior, in code this PR does not touch).token-vaulthas its own, unrelated build errors and is not touched here.closes #820