Skip to content

Fix monaco editor context menu paste by forcing loader to use monaco 0.56.0 - #1541

Open
ajlai-orkes wants to merge 2 commits into
mainfrom
fix/monaco-editor
Open

Fix monaco editor context menu paste by forcing loader to use monaco 0.56.0#1541
ajlai-orkes wants to merge 2 commits into
mainfrom
fix/monaco-editor

Conversation

@ajlai-orkes

Copy link
Copy Markdown
Contributor

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

conductor-ui-branch: fix/monaco-editor

Changes in this PR

Fix monaco editor context menu paste by forcing loader to use monaco 0.56.0

@monaco-editor/react@4.70 (latest version) uses @monaco-editor/loader@1.7.0 (latest) which uses monaco-editor 0.55.1. This fix uses the version defined in package.json

https://www.loom.com/share/1e563fbffa3840ecba527d512bc46c90

@nthmost-orkes nthmost-orkes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants