Skip to content

No update notifications in dev builds #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mp-orkes merged 1 commit into from
Oct 8, 2025
Merged

No update notifications in dev builds #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/updater/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,10 @@ func (s *UpdateState) HasUpdate(currentVersion string) bool {
if s.LatestVersion == "" {
return false
}
// Never show update notification for dev builds
if currentVersion == "dev" {
return false
}
return CompareVersions(s.LatestVersion, currentVersion) > 0
}

Expand Down
12 changes: 12 additions & 0 deletions internal/updater/state_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,18 @@ func TestHasUpdate(t *testing.T) {
currentVersion: "v1.0.0",
expected: false,
},
{
name: "dev version never shows update",
latestVersion: "v0.0.10",
currentVersion: "dev",
expected: false,
},
{
name: "dev version with no latest",
latestVersion: "",
currentVersion: "dev",
expected: false,
},
}

for _, tt := range tests {
Expand Down
Loading