feat: add CEP-6 channel notice support - #2639
Merged
Merged
Conversation
Collaborator
|
I found three issues:
|
baszalmstra
requested changes
Aug 4, 2026
baszalmstra
left a comment
Collaborator
There was a problem hiding this comment.
Most of the properties of what to query are on the query itself, not on the gateway. I think it would be much nicer if we can set the with_channel_notices on the gateway.query instead of on the gateway itself.
Contributor
Author
|
Changed that |
baszalmstra
requested changes
Aug 5, 2026
Notice fetches are now queued inside the query executor as channels are registered (user-supplied and CEP-42-discovered alike) and driven concurrently with subdir and record fetches, instead of as a second pass after the executor finished. Notice state is grouped in a new NoticeCollector shared by RepoDataQuery and NamesQuery. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
baszalmstra
approved these changes
Aug 5, 2026
baszalmstra
enabled auto-merge (squash)
August 5, 2026 20:18
Contributor
|
Details |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add end-to-end support for CEP-6 channel notices.
ChannelNotice,ChannelNoticeLevel, andChannelNoticestypesnotices.jsonthrough the repodata gatewayReporter::on_channel_noticeexpires_at, retry failures after a bounded interval, and coalesce concurrent fetchesnotices.jsonfromrattler-indexconfiguration for filesystem and S3 channelsexpired_atas a read alias while emitting CEP-6's standardexpires_atpixi-build-rust0.5 and exempt that backend from the workspace's seven-day package cutoff; Pixi 0.76 requires build API v6, so source-package CI cannot initialize the older backendExample
rattler-indexconfiguration:How Has This Been Tested?
cargo test -p rattler_repodata_gateway --all-features channel_noticecargo test -p rattler_index --test test_index test_index_writes_channel_metadatacargo clippy -p rattler_repodata_gateway -p rattler_index --all-features -- -D warningscargo check --manifest-path py-rattler/Cargo.tomlpixi run -m py-rattler/pixi.toml lint-pythonpixi run -m py-rattler/pixi.toml type-checkpixi run -m py-rattler/pixi.toml test -- tests/unit/test_gateway.py -qcargo check --manifest-path js-rattler/Cargo.tomlnpm test -- --runInBand src/Gateway.test.tsnpx tsc --noEmitwasm-pack build --mode normal --debug --target nodejsCoverage includes local and HTTP channels, query results and reporter callbacks, malformed entries, expiration refresh, request coalescing, response-size limits, indexing output, and Python/JavaScript configuration.
AI Disclosure
Tools: OpenAI Codex
Prompt:
Checklist: