feat(lock): store binary conda package locations verbatim - #2498
Open
hunger wants to merge 1 commit into
Open
Conversation
Change CondaBinaryData.location to Verbatim<UrlOrPath> so a relative 'conda:' path round-trips through the lock file. Refs prefix-dev/pixi#6322.
8 tasks
Collaborator
Author
|
@bas: I would like to have the verbatim data for this, so that we can round-trip relative channel URLs through pixi. I do not plan to support those officially, but we should not break them when a user sticks them into their files. |
baszalmstra
reviewed
Jun 11, 2026
| /// consumer to resolve against the lock file's base directory. | ||
| #[serde(rename = "conda")] | ||
| pub location: UrlOrPath, | ||
| pub location: Cow<'a, Verbatim<UrlOrPath>>, |
Collaborator
There was a problem hiding this comment.
Cant a Path already be relative though?
Collaborator
Author
There was a problem hiding this comment.
Of course.
But one of the first things we do is make it an absolute path and pass that around. I do not want to change that and still keep the "relative" information around.
Collaborator
There was a problem hiding this comment.
But the serialization also would then also only store either relative or absolute so you would have to reconstruct it anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change CondaBinaryData.location to Verbatim so a relative 'conda:' path round-trips through the lock file.
Relates to: prefix-dev/pixi#6322
AI Disclosure
Tools: Claude
Checklist: