feat: solving with conditional dependencies - #1530
Closed
wolfv wants to merge 4 commits into
Closed
Conversation
wolfv
changed the title
Contributor
Author
|
This is superseded by #1545 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This parses
foobar; if python >=3.12However, the condition is parsed as a simple string for the time being. I wonder if should be parsed as
matchspecagain? Possibly with some constraint that it cannot contain another condition? Althouhg I believe we also want to supportorandand(although I don't remember if one or both were implemented inresolvo.