feat: Add purls to IndexJson - #1303
Conversation
baszalmstra
left a comment
baszalmstra
left a comment
There was a problem hiding this comment.
Lets reference the CEP in the description and in the code maybe.
But looks good to me!
|
like this @baszalmstra? |
|
|
||
| /// A list of Package URLs identifying this package. | ||
| /// See this CEP: <https://github.com/conda/ceps/pull/63> | ||
| pub purls: Option<BTreeSet<PackageUrl>>, |
There was a problem hiding this comment.
Sorry we need to add #[serde(default, skip_serializing ...] here.
|
Shouldn't the CEP be first accepted before we implement this? |
|
The way it is implemented now it will not change any existing metadata (since it will not render into the JSON when the Option is None). We'll be careful to only allow this in |
|
our plan is to experiment a bit with those features first; it's easier to just merge these things in and then build possible implementations for rattler-tooling, otherwise you need to mess around a lot with git dependencies in rust |
4 participants
Description
xref conda/ceps#63