Skip to content

MNT: Remove 'pip install' options in recipes - #584

Open
matthewfeickert wants to merge 1 commit into
conda:mainfrom
matthewfeickert:mnt/remove-pip-install-options
Open

MNT: Remove 'pip install' options in recipes#584
matthewfeickert wants to merge 1 commit into
conda:mainfrom
matthewfeickert:mnt/remove-pip-install-options

Conversation

@matthewfeickert

Copy link
Copy Markdown

Resolves #582

Description

  • Remove --no-deps --no-build-isolation pip install options in recipes as the build tool (e.g. conda-build, rattler-build) will enforce all required pip install options itself at build time.

c.f.:

@matthewfeickert
matthewfeickert force-pushed the mnt/remove-pip-install-options branch from cd231f2 to d222e89 Compare November 18, 2024 07:29
@matthewfeickert
matthewfeickert marked this pull request as ready for review November 18, 2024 07:29
@matthewfeickert
matthewfeickert requested a review from a team as a code owner November 18, 2024 07:30
@matthewfeickert

Copy link
Copy Markdown
Author

This is ready for review.

@ocefpaf

ocefpaf commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

@wolfv we can't do this while we use conda-build b/c of the multiple outputs bug. However, if/when we drop conda-build, do you know if rattler-build will behave as expected with multiple outputs?

@matthewfeickert

Copy link
Copy Markdown
Author

we can't do this while we use conda-build b/c of the multiple outputs bug.

Out of curiosity, is there an issue for this?

@ocefpaf

ocefpaf commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

Out of curiosity, is there an issue for this?

I'm pretty sure there is one, or more, in conda-build. To be fair, are trying to keep conda-build on life support as we move to rattler-build, so I don't think anyone is working on that.

@marcelotrevisani

Copy link
Copy Markdown
Member

@wolfv we can't do this while we use conda-build b/c of the multiple outputs bug. However, if/when we drop conda-build, do you know if rattler-build will behave as expected with multiple outputs?

after we drop conda-build and start to use rattle, we could add this when the --strict-conda-forge flag is enabled

@matthewfeickert

matthewfeickert commented Nov 20, 2024

Copy link
Copy Markdown
Author

As I don't know the full history of things, or even the technical problems with conda-build, should I instead change this PR to add in --ignore-installed as that's also a flag set (conda/conda-build#5543) and then once conda-forge has gone full rattler-build removing all the flags can be revisited?

I also don't know if there is a projected timeline for full rattler-build adoption. (2025? 2026?)

@marcelotrevisani

Copy link
Copy Markdown
Member

As I don't know the full history of things, or even the technical problems with conda-build, should I instead change this PR to add in --ignore-installed as that's also a flag set (conda/conda-build#5543) and then once conda-forge has gone full rattler-build removing all the flags can be revisited?

I also don't know if there is a projected timeline for full rattler-build adoption. (2025? 2026?)

yeah, I think that would be nice to add the flag for now :)

* Remove --no-deps --no-build-isolation 'pip install' options in recipes as
  the build tool (e.g. conda-build, rattler-build) will enforce all required
  'pip install' options itself at build time.
@matthewfeickert
matthewfeickert force-pushed the mnt/remove-pip-install-options branch from d222e89 to bb62cde Compare August 11, 2026 23:29
@matthewfeickert

matthewfeickert commented Aug 11, 2026

Copy link
Copy Markdown
Author

... then once conda-forge has gone full rattler-build removing all the flags can be revisited?

@marcelotrevisani conda-forge has now changed to use the v1 / rattler-build recipe format as the default (c.f. PR #669). @wolfv can correct me if I'm wrong, but I believe that the issue with the flags being needed for recipes with multiple build outputs is now also resolved (c.f. conda-forge/conda-forge.github.io#2913, #582 (comment), and #582 (comment)). So I think this PR is ready for review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question: why is --no-deps --no-build-isolation set?

3 participants