Upgrades commonly used selectors - #80
Merged
Merged
Conversation
|
Looks great! |
wolfv
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This discovery came out of developing #77 and some discussions held on the public Conda Build Tools Element channel.
The commonly used
py<37selector expression is no longer supported in the new recipe format (see conda/ceps#71 and https://prefix-dev.github.io/rattler-build/latest/selectors/#selector-evaluation).These selector aliases/expressions have been superseded by the new
match()function in the V1 recipe format.This is the first issue we have found that occurs in when performing a full build with
rattler-buildBUT does not appear in a dry-run build. There are likely many more such issues to be discovered.This PR also stores
/build/skipexpressions as a single value instead of a list. I believe this was a temporary workaround to a schema issue that has since been resolved inrattler-build.