Skip to content

[WIP] Refactoring on Source Parsing Related Functions from #316 - #341

Closed
srilman wants to merge 2 commits into
conda:mainfrom
srilman:new-sourcefile-breakdown
Closed

[WIP] Refactoring on Source Parsing Related Functions from #316#341
srilman wants to merge 2 commits into
conda:mainfrom
srilman:new-sourcefile-breakdown

Conversation

@srilman

@srilman srilman commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

Description

This PR is just the first 2 commits of #316, split into a new PR and rebased against main. This is because these 2 commits only perform the following:

  • Move the make_lock_spec and parse_source_files functions from conda_lock.py to src_parser/__init__.py
  • Move the parse_pyproject_toml function to the end of pyproject_toml.py

@srilman
srilman requested a review from a team as a code owner February 9, 2023 23:45
@netlify

netlify Bot commented Feb 9, 2023

Copy link
Copy Markdown

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 55b5fe2
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63e5857d09fa470008b51edd
😎 Deploy Preview https://deploy-preview-341--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@srilman srilman changed the title Refactoring on Source Parsing Related Functions from #316 [WIP] Refactoring on Source Parsing Related Functions from #316 Feb 9, 2023
Comment thread conda_lock/conda_lock.py
platform_overrides=platform_overrides,
virtual_package_repo=virtual_package_repo,
required_categories=required_categories if filter_categories else None,
pip_support=PIP_SUPPORT,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, is this based on before or after #340?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is based on before. I'm going to wait for #340 to me merged first before fixing this PR. Plus, I will apply some of the comments from #316 to this PR. Thats why its [WIP] for now.

@srilman srilman closed this Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants