Typing improvements - #303
Merged
Merged
Conversation
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
The _BaseDependency class is never used except for inheritance.
maresb
force-pushed
the
typing-improvements
branch
from
December 31, 2022 19:13
91fce1f to
64f5922
Compare
maresb
marked this pull request as ready for review
January 1, 2023 10:42
srilman
approved these changes
Jan 1, 2023
srilman
left a comment
srilman
left a comment
Contributor
There was a problem hiding this comment.
This looks great! I was definitely a bit confused looking at the PyPi solver, so good to see this change.
mariusvniekerk
approved these changes
Jan 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to clarify some things about the various types in order to start reviewing #300. Along the way I documented my findings as type annotations.