Skip to content

Check for windows specific site-packages path - #950

Closed
soapy1 wants to merge 2 commits into
conda:mainfrom
soapy1:fix-search-python-tests
Closed

Check for windows specific site-packages path#950
soapy1 wants to merge 2 commits into
conda:mainfrom
soapy1:fix-search-python-tests

Conversation

@soapy1

@soapy1 soapy1 commented May 21, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes windows tests, for example https://github.com/conda/conda-libmamba-solver/actions/runs/26194609277/job/77277180835?pr=949

With the latest release of libmambapy (2.6.2) querying for python packages from windows will inject windows specific python_site_packages_path data into results. ref: mamba-org/mamba#4286

Checklist - did you ...

  • [ ] Add a file to the news directory (using the template) for the next release's release notes?
  • [] Add / update necessary tests?
  • [ ] Add / update outdated documentation?

@soapy1
soapy1 requested a review from a team as a code owner May 21, 2026 23:31
@github-project-automation github-project-automation Bot moved this to 🆕 New in 🔎 Review May 21, 2026
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 21, 2026
@soapy1
soapy1 marked this pull request as draft May 21, 2026 23:31
@soapy1
soapy1 force-pushed the fix-search-python-tests branch 2 times, most recently from 7e2ca06 to be2c5d9 Compare May 22, 2026 17:26
@soapy1
soapy1 marked this pull request as ready for review May 22, 2026 17:28
@soapy1
soapy1 force-pushed the fix-search-python-tests branch from 15077a1 to 83aeba5 Compare May 22, 2026 17:28

@isuruf isuruf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a xfail on windows.

@github-project-automation github-project-automation Bot moved this from 🆕 New to 🏗️ In Progress in 🔎 Review May 22, 2026
@soapy1

soapy1 commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

This should be a xfail on windows.

good idea!

@jezdez

jezdez commented May 28, 2026

Copy link
Copy Markdown
Member

Hmm, but mamba-org/mamba#4268 seems to only been in 2.6.x?

@soapy1

soapy1 commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

Hmm, but mamba-org/mamba#4268 seems to only been in 2.6.x?

yep. The tests run against libmamba 2.6.2

libmamba                       2.6.2                   h06825f5_0       conda-forge
libmamba-spdlog                2.6.2                   hb777e2b_0       conda-forge
libmambapy                     2.6.2                   py310ha763336_0  conda-forge

This is consistent with the project requirements which specify requiring conda-forge::libmambapy>=2.0.0.

Looks like there is already a fix 🎈.

@soapy1

soapy1 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

@jezdez looks like there is maybe a new mamba release coming soon #956 🍰

Another approach to make tests pass here is to restrict the libmambapy version to != 2.6.2?

@jezdez

jezdez commented Jun 3, 2026

Copy link
Copy Markdown
Member

@jezdez looks like there is maybe a new mamba release coming soon #956 🍰

Another approach to make tests pass here is to restrict the libmambapy version to != 2.6.2?

I like the last one, we rarely come back from xfail 😬

@soapy1 soapy1 closed this Jun 3, 2026
@github-project-automation github-project-automation Bot moved this from 🏗️ In Progress to 🏁 Done in 🔎 Review Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed [bot] added once the contributor has signed the CLA

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants