Replace IndexedSet with Sequence / tuple; additional typing tweaks - #879
Draft
dholth wants to merge 2 commits into
Draft
Replace IndexedSet with Sequence / tuple; additional typing tweaks#879dholth wants to merge 2 commits into
dholth wants to merge 2 commits into
Conversation
conda-bot
added
the
cla-signed
dholth
commented
Feb 27, 2026
| force_remove: bool | _Null = NULL, | ||
| should_retry_solve: bool = False, | ||
| ) -> IndexedSet[PackageRecord]: | ||
| ) -> Sequence[PackageRecord]: |
Contributor
Author
There was a problem hiding this comment.
Base class only says (in an inaccurate docstring) that this returns a tuple of PackageRef
Member
There was a problem hiding this comment.
We can go with the more accurate:
Suggested change
| ) -> Sequence[PackageRecord]: | |
| ) -> tuple[PackageRecord, ...]: |
Contributor
Author
There was a problem hiding this comment.
tuple is more concrete, but Sequence is accurate and has a nicer "all elements of the same type" annotation without ...
jaimergp
reviewed
Feb 27, 2026
|
|
||
| @property | ||
| def current_solution(self) -> IndexedSet[PackageRecord]: | ||
| def current_solution(self) -> Sequence[PackageRecord]: |
Member
There was a problem hiding this comment.
Suggested change
| def current_solution(self) -> Sequence[PackageRecord]: | |
| def current_solution(self) -> tuple[PackageRecord, ...]: |
jaimergp
reviewed
Feb 27, 2026
| return {name: spec for name, spec in self.specs.items() if name.startswith("__")} | ||
|
|
||
| def early_exit(self) -> IndexedSet[PackageRecord] | None: | ||
| def early_exit(self) -> Sequence[PackageRecord] | None: |
Member
There was a problem hiding this comment.
Suggested change
| def early_exit(self) -> Sequence[PackageRecord] | None: | |
| def early_exit(self) -> tuple[PackageRecord, ...] | None: |
Contributor
Author
There was a problem hiding this comment.
I usually put the more generic type in annotations. Sequence[] would allow IndexedSet or tuple or list for example. Especially in the base class in conda.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See conda/conda#15742
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?