Skip to content

Update repodata_revisions to be a dict instead of a list - #340

Merged
danyeaw merged 4 commits into
mainfrom
338-repodata-revisions-dict
Aug 10, 2026
Merged

Update repodata_revisions to be a dict instead of a list#340
danyeaw merged 4 commits into
mainfrom
338-repodata-revisions-dict

Conversation

@dholth

@dholth dholth commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Description

Fix #338

AI-assisted

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 7, 2026
@github-project-automation github-project-automation Bot moved this to 🆕 New in 🔎 Review Aug 7, 2026
"conda": dict[str, dict[str, Any]],
"whl": dict[str, dict[str, Any]],
},
closed=True,

@dholth dholth Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closed avoids type complaints when iterating over .values() in _make_repodata_revision_data

@danyeaw danyeaw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dholth, thanks for working on this! Just a comment about the v3 key. It looks like docs/v3-repodata.md also has it set as "3":.

Comment thread tests/test_index.py Outdated
{
"revision": 3,
"repodata_revisions": {
3: {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CEP draft which is being voted on now is using "v3":, see conda/ceps#146

@dholth

dholth commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

I updated the key to "v3" instead of 3 or "3"

Comment thread news/338-repodata-revisions-map Outdated
@github-project-automation github-project-automation Bot moved this from 🆕 New to ✅ Approved in 🔎 Review Aug 8, 2026
@danyeaw
danyeaw merged commit 5ac3da2 into main Aug 10, 2026
28 checks passed
@danyeaw
danyeaw deleted the 338-repodata-revisions-dict branch August 10, 2026 16:33
@github-project-automation github-project-automation Bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed [bot] added once the contributor has signed the CLA

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

info.repodata_revisions is emitted as a list but rattler expects a map in py-rattler 0.25.0

3 participants