Skip to content

Removing conda exception for activation in Windows - #6084

Open
ryanskeith wants to merge 1 commit into
mainfrom
fix-windows-skips-with-conda
Open

Removing conda exception for activation in Windows#6084
ryanskeith wants to merge 1 commit into
mainfrom
fix-windows-skips-with-conda

Conversation

@ryanskeith

Copy link
Copy Markdown
Contributor

Description

Partially fixes issue #6069 (other changes needed to take place in another repository (namely conda). Windows will now be inline with what the other platforms do. See issue for more background.

Changes

  • Removed conda clause from windows activation check
  • Moved the check from m.config.activate -> m.activate_build_script (which brings Windows inline with other platforms)
    • Just as an FYI, activate_build_script -> m.conda.activate and self.get_value("build/activate_in_script") is not False
  • Added parametrized tests

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@ryanskeith
ryanskeith requested a review from a team as a code owner August 7, 2026 21:14
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 7, 2026
@github-project-automation github-project-automation Bot moved this to 🆕 New in 🔎 Review Aug 7, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 7, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks


Comparing fix-windows-skips-with-conda (fb9eaa4) with main (3b6a390)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed [bot] added once the contributor has signed the CLA

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

2 participants