Omit REQUESTS_CA_BUNDLE from build env defaults - #6083
Open
ryanskeith wants to merge 2 commits into
Open
Conversation
Pass it through via get_default like SSL_CERT_FILE so an empty value is not injected into subprocess environments (botocore). Co-authored-by: Cursor <cursoragent@cursor.com>
ryanskeith
marked this pull request as ready for review
August 7, 2026 19:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6063: stop injecting
REQUESTS_CA_BUNDLE=""into the build environment when the variable is unset.Changes
get_defaultmechanism so it is only present when set in the host environment.Notes for review
HTTP_PROXY/HTTPS_PROXYon the olderos.getenv(..., "")path for now; they have the same pattern and could follow in a follow-up.REQUESTS_CA_BUNDLEis inos_varsso it applies on all platforms (including Windowsrequests/botocore).Testing
Here is a LLM generated test used for local testing: