Wrap native win-arm64 scripts with a start /machine launcher - #6047
Conversation
conda-bot
added
the
cla-signed
jaimergp
changed the title
start /machine launcher
| env["PROCESSOR_ARCHITECTURE"] = build_arch | ||
| if build_arch == get_native_windows_architecture(): | ||
| env.pop("PROCESSOR_ARCHITEW6432", None) |
There was a problem hiding this comment.
Note these are being set to whatever os.environ carries at
conda-build/conda_build/environ.py
Lines 685 to 686 in f2b6617
so we need to undo that here
| raise OSError("This function is only supported on Windows.") | ||
|
|
||
| if sys.version_info >= (3, 12): | ||
| return platform.machine() or None |
There was a problem hiding this comment.
This will change if python/cpython#98962 is fixed and I want to push for that.
| ${{ env.PYTEST_MARKER && '-m "' || ''}}${{ env.PYTEST_MARKER }}${{ env.PYTEST_MARKER && '"' || ''}} | ||
| ${{ matrix.pytest-expression && '-k "' || ''}}${{ matrix.pytest-expression }}${{ matrix.pytest-expression && '"' || ''}} |
There was a problem hiding this comment.
Maybe these lines are sufficiently complex enough to warrant a comment? 😅 I'm struggling to understand exactly what this is doing. Especially because of the doubled env.PYTEST_MARKER and matrix.pytest-expression usage.
There was a problem hiding this comment.
These are ternary operators in JavaScript, adapted to Github Actions. Equivalent to '-m "' if env.PYTEST_MARKER else ''. So if PYTEST_MARKER is set, then we write -m "{{ env.PYTEST_MARKER }}".
6 participants
Description
Closes #6048 by:
start /mahcinelauncherPROCESSOR_ARCHITECTUREand friends so they are not blindly inherited and injected from the parent processChecklist - did you ...
newsdirectory (using the template) for the next release's release notes?