Fix platform config values for v1 recipes - #6015
Conversation
beckermr
left a comment
There was a problem hiding this comment.
The test suite apparently didn't catch what appears to be a pretty fundamental issue here. I think we should add tests specifically for this error.
Yes, I'm working on a test for this atm |
|
Ahh sorry. I thought this was ready for review! |
dc5b948 to
dbda7b3
Compare
|
AFAIK, rattler-build does not read Is |
Yes, I know that the platform config settings will be ignored there if it's attempted with the CLI as it gives a warning.
|
The code is currently trying to set platform configuration values by checking `config.variant` object which is not valid as we are not loading config files through conda-build's mechanism. Fix this by obtaining the settings from the variant config loaded in the rattler compat code. While at it, cleanup redundant command check in `run_rattler()`.
The code is currently trying to set platform configuration values by checking
config.variantobject which is not valid as we are not loading config files through conda-build's mechanism and any configuration value will not get applied but rather fall back to the defaultconfig.subdir. Fix this by obtaining the settings from the variant config loaded in the rattler compat code.While at it, cleanup redundant command check in
run_rattler().Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?