Fix SP_DIR resolving to wrong path for free-threading Python builds - #5990
Fix SP_DIR resolving to wrong path for free-threading Python builds#5990jschueller wants to merge 2 commits into
Conversation
conda-bot
added
the
cla-signed
jsmolic
left a comment
jsmolic
left a comment
There was a problem hiding this comment.
Thanks for the PR, is there any particular reason why this is marked as draft?
We'd need a test to verify the correct behavior before merging.
Are you willing to finish the work in this PR @jschueller?
jsmolic
left a comment
jsmolic
left a comment
There was a problem hiding this comment.
We need a news item in a similar format as https://github.com/conda/conda-build/blob/e4cfe88586634f6adba01adb768668ef563f6f29/news/5987-fix-duplicate-rpaths-macos.md?plain=1, could you please also add this?
|
pre-commit.ci autofix |
- Prefer exact python{py_ver} directory match in get_stdlib_dir()
before falling back to the glob pattern, so that python3.13t/
is correctly selected when py_ver is "3.13t"
- Honor is_freethreading variant key in get_py_ver() by appending
the "t" suffix to the Python version string when the key is set
Closes conda#5563
| return ".".join(py.split(".")[:2]) | ||
| ver = ".".join(py.split(".")[:2]) | ||
| if config.variant.get("is_freethreading", False) and not ver.endswith("t"): | ||
| ver += "t" |
There was a problem hiding this comment.
I don't think this is a good change. freethreading doesn't have anything to do with the version. Similar to other options like unicode support (back in 2.x days) and other implementations like pypy, we don't include the ABI in this field
There was a problem hiding this comment.
@isuruf Do you have any pointers in where should this be fixed in the code?
4 participants
Closes #5563