CEP 44: clarify extras matchspec - #177
Merged
Merged
Conversation
The Specification only showed the scalar form `pkg[extras="group-name"]`
and described the value as "a string or a list of string" without
pinning down the list syntax, whether the `[a-z0-9_.+-]{1,64}` grammar
binds the selector, or how case is handled. This left implementations to
guess (e.g. quoted-list handling, uppercase names).
Clarify that:
- the list form is a bracketed, comma-separated list, e.g. `[extras=[a, b]]`
- names may be optionally single/double quoted; surrounding whitespace is ignored
- selector names must obey the same group-name grammar as `extra-depends`
keys, compared case-sensitively with no normalization
- a non-conforming name makes the MatchSpec invalid (must be rejected)
- referencing an absent group name is a no-op, not an error
jaimergp
reviewed
Jul 2, 2026
jaimergp
reviewed
Jul 2, 2026
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
jaimergp
changed the title
extras matchspec
jaimergp
reviewed
Jul 2, 2026
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Contributor
Author
|
Thank you @jaimergp for fixing the PR up! Idk if we need a vote or more core people to chime in but IMO this is just a clarification and we could merge it (if we agree that quotes are supported). |
Member
|
I don't think we need a vote, but I do want more eyes on this because the diff goes beyond "typo fix". I'll mention it in the next community meeting too and it should be ok. |
carterbox
reviewed
Jul 10, 2026
jaimergp
reviewed
Jul 15, 2026
jaimergp
reviewed
Jul 24, 2026
|
|
||
| - MAY be quoted with balanced single or double quotes; the quotes carry no semantic difference. | ||
| - MAY be wrapped with whitespace, which MUST be ignored. | ||
| - MUST match the same `[a-z0-9_.+-]{1,64}` grammar as the `extra-depends` keys. A `MatchSpec` whose `extras` value contains a name that does not match this grammar is invalid and MUST be rejected. |
Member
There was a problem hiding this comment.
This rejects glob strings. Is that intended? I think it's a good idea to not allow them for now (why would I want to install extras=["known-prefix-*"]?). In that case, maybe we should mention that these items MUST be string literals matching that grammar.
Contributor
Author
There was a problem hiding this comment.
yeah globbing was never discussed for extras (Only for flags).
jaimergp
reviewed
Jul 24, 2026
Comment on lines
+43
to
+45
| This new field must be selectable by `MatchSpec` syntax using the `extras` keyword inside square brackets, the value of which MUST be a string or a list of string targeting group names. | ||
|
|
||
| Individual names in the list: |
Member
There was a problem hiding this comment.
Suggested change
| This new field must be selectable by `MatchSpec` syntax using the `extras` keyword inside square brackets, the value of which MUST be a string or a list of string targeting group names. | |
| Individual names in the list: | |
| This new field must be selectable by `MatchSpec` syntax using the `extras` keyword inside square brackets, the value of which MUST be a string or a list of string targeting group names. Each of these strings: |
(so it applies to both scalar and lists)
jaimergp
reviewed
Jul 24, 2026
jaimergp
reviewed
Jul 24, 2026
Comment on lines
+47
to
+48
| - MAY be quoted with balanced single or double quotes; the quotes carry no semantic difference. | ||
| - MAY be wrapped with whitespace, which MUST be ignored. |
Member
There was a problem hiding this comment.
This can go away if we accept the YAML 1.2 suggestion.
…matchspec # Conflicts: # cep-0044.md
jaimergp
reviewed
Aug 10, 2026
jaimergp
reviewed
Aug 10, 2026
jaimergp
reviewed
Aug 11, 2026
jaimergp
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for submitter
cep-0000.mdnamedcep-XXXX.mdin the root level.CEP XX: Amend XYZ.## Changelogsection right above the final "Copyright" section with an item that uses syntaxYYYY-MM-DD: Brief explanation of changes.Checklist for CEP approvals
${greatest-number-in-main} + 1.cep-XXXX.mdfile has been renamed accordingly.# CEP XXXX -header has been edited accordingly.pre-commitchecks are passing.