Skip to content

Protobuf320 and GRPC migration - #236

Closed
hmaarrfk wants to merge 5 commits into
conda-forge:mainfrom
hmaarrfk:protobuf20
Closed

Protobuf320 and GRPC migration#236
hmaarrfk wants to merge 5 commits into
conda-forge:mainfrom
hmaarrfk:protobuf20

Conversation

@hmaarrfk

@hmaarrfk hmaarrfk commented May 15, 2022

Copy link
Copy Markdown
Contributor

Closes #232
Closes #228

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'tensorflow-base' output doesn't have any tests.

@hmaarrfk hmaarrfk changed the title WIP: Protobuf320 WIP: Protobuf320 and GRPC migration May 15, 2022
@hmaarrfk

Copy link
Copy Markdown
Contributor Author

This compiles fine for linux CPU. Time to check CPU + CUDA 11.2 before running a full suite of builds.

@hmaarrfk

Copy link
Copy Markdown
Contributor Author

Dear xhochy,

This seems to be passing with linux both without cuda, and with cuda 11.2. I'm starting to build out linux, but if you could build out osx that would be greatly appreciated

@hmaarrfk hmaarrfk changed the title WIP: Protobuf320 and GRPC migration Protobuf320 and GRPC migration May 15, 2022
@xhochy

xhochy commented May 16, 2022

Copy link
Copy Markdown
Member

@hmaarrfk I'm nearly done with #205 (i.e. only CUDA 10.2 is missing). I would prefer to merge that first and then rebase.

@xhochy

xhochy commented May 16, 2022

Copy link
Copy Markdown
Member

If you really want this PR, then we should merge it to a 2.7.x branch.

@hmaarrfk

Copy link
Copy Markdown
Contributor Author

lets finish 205 first.

@ngam

ngam commented May 16, 2022

Copy link
Copy Markdown
Contributor

Sorry to jump in out of nowhere, please consider adding the xla option and cpu_count from my otherwise useless PR in #235, both are innocent additions with little consequences. Then we can skip building 2.8.1 entirely (it is only security fixes, but you're welcome to simply swap 2.8.1 for 2.8.0 in PR #205)

@ngam

ngam commented May 16, 2022

Copy link
Copy Markdown
Contributor

Happy to initiate a PR for 2.9.0 in a week if not

@hmaarrfk

Copy link
Copy Markdown
Contributor Author

I think the outputs of #205 are likely set in stone since xhochy is quite deep in the build process (it takes 2-3 days on a single large machine of mine to build this so it isn't the easiest thing to build).

However, if you create a checklist then we have a list of fixes that we won't forget.

@hmaarrfk

Copy link
Copy Markdown
Contributor Author

didn't know 2.9.0 was coming out, we just got a handle on 2.8 :D

@ngam

ngam commented May 16, 2022

Copy link
Copy Markdown
Contributor

I think the outputs of #205 are likely set in stone since xhochy is quite deep in the build process (it takes 2-3 days on a single large machine of mine to build this so it isn't the easiest thing to build).

However, if you create a checklist then we have a list of fixes that we won't forget.

Yes, I understand, I will make a checklist and we will include those in the 2.9.x builds :)

For future reference, I can build tensorflow 2.8.x cuda112 in under 1 hour (using my experimental conda-smithy with singularity), but it is a little tricky as I need to babysit the machine. Happy to shoulder some builds. I can also likely shoulder some osx builds in the near future. I hate to repeat this, but I also really don't want you two to shoulder all the build all the time!

@ngam

ngam commented May 16, 2022

Copy link
Copy Markdown
Contributor

didn't know 2.9.0 was coming out, we just got a handle on 2.8 :D

2.9 is days away (they've just released the patches for 2.6, 2.7, and 2.8) 🥵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants